Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 94.09% 94.45% +0.35%
==========================================
Files 13 13
Lines 847 847
==========================================
+ Hits 797 800 +3
+ Misses 50 47 -3
Continue to review full report at Codecov.
|
| a += b | ||
| np.testing.assert_array_equal(a.to_numpy(), np.array([2, 4, 6, 8])) | ||
|
|
||
| def testIaddSelfArray(self): |
There was a problem hiding this comment.
David, delete this test, as it may collision with PR 37.
There was a problem hiding this comment.
Don't worry about that, I will pull the changes and fix it when PR 37 is merged. Right now this branch have a pull from the branch of PR 37.
| """ Stomp algorithm to calculate the matrix profile between `t` and itself using a subsequence length of `m`. | ||
| This method filters the trivial matches. | ||
|
|
||
|
|
There was a problem hiding this comment.
There is an extra empty line.
| @@ -77,6 +77,10 @@ def find_best_n_motifs(profile, index, m, n, self_join=False): | |||
| def stomp(first_time_series, second_time_series, subsequence_length): | |||
| """ Stomp algorithm to calculate the matrix profile between `ta` and `tb` using a subsequence length of `m`. | |||
There was a problem hiding this comment.
Does this method filter trivial matches? if so, please add, "This method filters the trivial matches.", as the one below
There was a problem hiding this comment.
This method doesn't filter trivial matches as it consider that both time series are different.
3 participants
Make sure you have checked all steps below.
Description
Tests
Commits
License
Documentation